Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the dependencies in README.md #1387

Closed
wants to merge 1 commit into from

Conversation

nichamon
Copy link
Collaborator

The patch clarifies that Python3 and munge development libraries are dependencies.

The patch clarifies that Python3 and munge development libraries are
dependencies.
* libmunge (for Munge LDMS Authentication plugin)
* Python >= 3.6 and Cython >= 0.25 (for the LDMS Python API and ldmsd_controller)
* libmunge development library (for Munge LDMS Authentication plugin)
* Python >= 3.6 development library and Cython >= 0.25 (for the LDMS Python API and the LDMSD Interface, ldmsd_controller)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we rely on 0.29 for Cython now., but the issue that prompted this was that the user in question didn't read any of this, they just went directly to the Building section which doesn't reference these dependencies. So I think we need a pointer in the "Building" section that refers back to the dependencies section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narategithub could you please collect the versions from the build container that we have? I know it's a pain, but we know that works. Also this readme should refer to that container and how one builds using it.

* libmunge (for Munge LDMS Authentication plugin)
* Python >= 3.6 and Cython >= 0.25 (for the LDMS Python API and ldmsd_controller)
* libmunge development library (for Munge LDMS Authentication plugin)
* Python >= 3.6 development library and Cython >= 0.25 (for the LDMS Python API and the LDMSD Interface, ldmsd_controller)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narategithub could you please collect the versions from the build container that we have? I know it's a pain, but we know that works. Also this readme should refer to that container and how one builds using it.

@narategithub
Copy link
Collaborator

Closing this one and use #1388 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants